Skip to content

Conversation

MaxDesiatov
Copy link

No description provided.

compnerd and others added 30 commits May 1, 2020 12:59
This function is used at one site and is an internal function.  Host
libraries are always built in a single configuration, just inline it to
avoid unnecessarily reparsing arguments.
This is just a cleanup of the implementation of
`add_swift_host_library`, reorganizing the flag computation and
application as well as the property setting.
Methods and closures use the same convention for the self/context argument, so when a
partial_apply applies a single argument to a method implementation, the closure can be formed
by simply tupling the implementation and self argument together. This doesn't yet cover a lot
of situations the compiler generates, but it prepares IRGen for an IRGen SIL pass that can
take the heavy lifting of partial_apply lowering off of IRGen by reducing more complex closures
into these "simple" cases, eventually reducing the number of partial_apply forwarding thunks and
extra closure allocations generated.
Introduced 'TypeAnnotationBegin' chunk kind for grouping the result type
name chunks.

rdar://problem/62617558
In terms of Swift [-9.5, 2.5, 3.0, 21.25, .nan] != [-9.5, 2.5, 3.0, 21.25, .nan] because Double.nan != Double.nan
Make derivative forwarding thunks use original function's linkage instead of the
derivative function's, stripping external.

This is consistent with the linkage of differentiability witnesses.

Clarify AutoDiff linkage-related comments.

Resolves TF-1160: TBDGen error due to incorrect derivative thunk linkage.
…swiftlang#31727)

Create `DerivativeFunctionTypeError` representing all potential derivative
function type calculation errors.

Make `AnyFunctionType::getAutoDiffDerivativeFunctionLinearMapType` return
`llvm::Expected<AnyFunctionType *>`. This is much safer and caller-friendly
than performing assertions.

Delete hacks in `@differentiable` and `@derivative` attribute type-checking
for verifying that `Differentiable.TangentVector` type witnesses are valid:
this is no longer necessary.

Robust fix for TF-521: invalid `Differentiable` conformances during
`@derivative` attribute type-checking.

Resolves SR-12793: bad interaction between `@differentiable` and `@derivative`
attribute type-checking and `Differentiable` derived conformances.
…objc metatype conversions (swiftlang#31595)"

This reverts commit 488333c.

It looks like this might have caused a heap-use-after free on an asan
bot.

rdar://63135437
IRGen: Restore handling of "simple" partial_apply instructions.
We were accidentally using the system libicu instead of building it,
causing version mismatches.
[preset] Add missing libicu dependencies to package presets
…tedtypename-rdar62617558

[CodeCompletion] Annotated result type name
…tch-and-foundation-deps-for-swiftpm

[build-script] When we build Dispatch and Foundation, pass them down to SwiftPM's build
…olchain

This is useless and leads in duplicated symbol file in the LLDB
framework.

rdar://61702866
…lone delegate class. NFC

Module interface builder used to maintain a separate compiler instance for
building Swift modules. The configuration of this compiler instance is also
useful for dependencies scanner because it needs to emit front-end compiler invocation
for building Swift modules explicitly.

This patch refactor the configuration out to a delegate class, and the
delegate class is also used by the dependency scanner.
Add new pattern in SILCombine to optimize redundant thick to objc metatype conversions

Add pattern to catch the following redundant conversion:

%tmp1 = thick_to_objc_metatype %x
%tmp2 = objc_to_thick_metatype %tmp1
...
%tmp3 = <sil operation> %tmp2

to:

%tmp3 = <sil operation> %x

Similarly add pattern for redundant conversion of objc_to_thick_metatype
followed by thick_to_objc_metatype.

Fixes rdar://62932799
slavapestov and others added 13 commits May 12, 2020 19:42
We should use the source location of the call site, and not the enum
element declaration, otherwise we emit incorrect debug info.

Fixes <rdar://problem/63067437>.
Check SPI attribute usage in frozen types and on protocol requirements
[WebAssembly] Add SWIFT_ONCE_F implementation to Lazy.h
[NFC] Fold performParseOnly into performSemaUpTo
…aning

[presets] Do not copy Swift resource dir into LLDB when building a to…
…-variable-fix

[ASTPrinter] Fix issue where printing if-let variables shows their type as optional
…onstructor

SILGen: Fix source location for the enum payload argument source
…nostics-keypath

[Diagnostics] Improve keypath diagnostic  when cannot be inferred by context
…ext-delegate

ModuleInterface: refactor compiler instance configuration to a standalone delegate class. NFC
…constqual

[NFC] AST: Const-qualify GenericSignatureImpl
…g#31745)

Ensure that semantic member accesors have empty linear map structs.
Semantic member accessor VJPs do not accumulate any callee pullbacks.

Resolves SR-12800: SIL verification error.
…merge

# Conflicts:
#	cmake/modules/AddSwift.cmake
#	include/swift/Basic/Lazy.h
@MaxDesiatov MaxDesiatov merged commit b76ebbd into swiftwasm May 13, 2020
@MaxDesiatov MaxDesiatov deleted the maxd/master-merge branch May 13, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.