[pull] swiftwasm-release/5.3 from release/5.3 #992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Fixes <rdar://problem/62747693> (cherry picked from commit 8946435)
for fast completions. Options may affect the parsing result. Also, don't collect interface hash tokens inside inactive blocks. (cherry picked from commit ec0c948)
Register DynamicSubscriptExpr's index expression as a call argument in MiscDiagnostics to avoid it being diagnosed as a single element labelled tuple. Resolves SR-12799.
Previously we would always consider an AnyObject subscript lookup to be ambiguous if there was a candidate in both a class and protocol, even if the selectors and types matched. This was due to the protocol's generic signature preventing the signatures from being coalesced. Tweak the logic to strip generic signatures when comparing for AnyObject lookup, matching what we do for @objc methods. Resolves SR-8611. Resolves rdar://43645564 & rdar://62906344.
(cherry picked from commit 833d2cd)
…stifconfig [5.3][CodeCompletion] Inherit options when parsing new buffer
[5.3] Remove stray backtick in docs.
[5.3] Check SPI usage of implementation-only types, in frozen types and on protocol requirements
[5.1 Compatibility library] Add missing #include
MaxDesiatov
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )