Skip to content

Conversation

pull[bot]
Copy link

@pull pull bot commented May 14, 2020

See Commits and Changes for more details.


Created by pull[bot]. Want to support this open source service? Please star it : )

AnthonyLatsis and others added 30 commits April 23, 2020 07:15
Now that the integrated REPL has been removed,
there is always an associated decl context, and
we can assert as such.
Rather than maintain a separate bit, check if the
associated decl context is for the ModuleDecl.
Adjust `SILModule::createEmptyModule` to accept a
FileUnit or ModuleDecl, and pass the corresponding
context for SIL generation and parsing. This
change means that SIL parsing will now correctly
use a SourceFile associated context when in
single-file mode.
…bodies

This allows us to push the validation and, importantly, the mutation of this flag into the compiler invocation where it belongs.
The constraint system will need this if it wants to disable debug mode for serialized modules
This eliminates the final source of mutation of the TypeCheckerFlags on the ASTContext.
Remove the use of the `LLVM.h` forward declarations from the
compatibility shims.  This allows us to fully isolate the target side
from the LLVM namespace ensuring that we prevent ODR violations when
LLVM is linked into the same address space.
…the parser library

We don't need it and it causes the parser library to reference non-public symbols.
This adjusts the use of `SmallVectorImpl` to allow the runtime to use
inline namespaces for its local copy of LLVMSupport.
The parser used to rewrite

if let x: T

into

if let x: T?

This transformation is correct at face value, but relied on being able
to construct TypeReprs with bogus source locations. Instead of having
the parser kick semantic analysis into shape, let's perform this
reinterpretation when we resolve if-let patterns in statement
conditions.
Now that the parser no longer constructs invalid TypeReprs for if-lets,
printing the annotation here will always reflect what the user actually
wrote.

rdar://62894516
Const-Qualify LangOptions and TypeCheckerOptions
standard library: remove use of `LLVM.h` in the compatibility
runtime: namespace SmallVectorImpl for inline namespace
[overlay] Remove unnecessary Optional unwrapping
The runtime has an embedded copy of LLVMSupport which provides
`llvm::function_ref` as `__swift::__runtime::llvm::function_ref`.  This
forward declaration can cause the inlined namespaces to be ignored.
Remove the forward declaration for the runtime.
They both do essentially the same thing, with the
single-file request being the single-element case
of the whole-module request, with only the call to
`getAllForModule` really caring about the
difference.
Remove The Parser Hack For If-Let
runtime: remove forward declaration of `llvm::function_ref`
…about-anchors

[TypeChecker/Doc] NFC: Locators now refer to a generic AST node inste…
…ing a toolchain"

This reverts commit a49e872.

This had the intended effect, but it also means we cannot run the tests on
the pakcage bots anymore, which is not desirable.
slavapestov and others added 4 commits May 13, 2020 23:32
…erence

AssociatedTypeInference: Allow inference in compatible constrained extensions
…tomics

Make the lazy assignment of an assoociated type/wtable atomic
Revert "[presets] Do not copy Swift resource dir into LLDB when build…
@MaxDesiatov MaxDesiatov merged commit 171e819 into swiftwasm May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.