Remove clone-deep dependency #1763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the clone-deep dependency is possible by writing a custom clone function for Line Coordinates. This closes swimlane#1762
LeoFalco
approved these changes
Jul 21, 2022
|
Replaced by #1771 |
PhilFlash
added a commit
to PhilFlash/ngx-charts
that referenced
this pull request
Nov 11, 2022
…anrideshark in pr swimlane#1763 (with rfdc, there is the same message like clone-deep: CommonJS or AMD dependencies can cause optimization bailouts)
9 tasks
PhilFlash
added a commit
to PhilFlash/ngx-charts
that referenced
this pull request
Mar 28, 2023
…anrideshark in pr swimlane#1763 (with rfdc, there is the same message like clone-deep: CommonJS or AMD dependencies can cause optimization bailouts) ng-package.json: remove rfdc
9 tasks
PhilFlash
added a commit
to PhilFlash/ngx-charts
that referenced
this pull request
Feb 19, 2024
…anrideshark in pr swimlane#1763 (with rfdc, there is the same message like clone-deep: CommonJS or AMD dependencies can cause optimization bailouts)
8 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the clone-deep dependency is possible by writing a custom clone function for Line Coordinates.
This closes #1762
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Currently, a dependency on 4 year old
clone-deepcauses an optimization bailout warning, and an error in Angular 14 compilation.What is the new behavior?
Removing a function call which was only used once, and replacing it with a monomorphic function, improves the performance and removes this breaking error.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: