-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: Add SARIF output format #1
Conversation
|
||
## Questions | ||
|
||
- Does Brakeman have a sense of severity that we can map into the results? Should we default to "warning" for all results? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confidence
is a conflation of both severity and confidence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added 9b95383 to infer severity from confidence.
For referenceAdding a screenshot of how SARIF properties are treated in the GitHub Note the following properties are pulled into the UI from this example SARIF file: Notes
|
Yes, I can do this.
Another thought is to directly pull in some docs. I believe Code Climate does/did this using what is in https://github.com/presidentbeef/brakeman/tree/main/docs/warning_types (in fact, that directory is just for them). However those docs are not currently up-to-date... but they can be updated. The content is from the Brakeman site which is licensed under Creative Commons. |
Great idea 👍 SARIF supports Markdown-formatted messages, I will see if there's a way to render these in the UI. |
Per feedback from SARIF validation review.
Since it appears as the rule name
This reverts commit 3181417.
To provide 'compiler error' appearance '46' becomes 'BRAKE0046', for example
I opened a new PR targeting |
Adds support for the SARIF format to brakeman.
Some helpful information on the SARIF format is here.