Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds some tests #234

Merged
merged 7 commits into from
Nov 9, 2014
Merged

Adds some tests #234

merged 7 commits into from
Nov 9, 2014

Conversation

jzelenkov
Copy link
Contributor

A set of unit and integration tests.

closes #94

@rodneyrehm
Copy link
Contributor

Hey Jev, nice work! Why did you put the test files in the demo directory? demo/sub-menus_test.html looks kinda weird…

@jzelenkov
Copy link
Contributor Author

@rodneyrehm I am reusing all HTMLs from demo/ directory. So integration tests are based on the demo pages.

Some demo pages are using alert() calls to verify functionality. PhantomJS doesn't support alert() calls (I assume it cannot render modal windows since it is a headless browser). So I had to modify those demo pages to use DOM manipulation instead. (added a div#msg to the <body>).

In the long run, I was thinking about using twitter bootstrap (after we fix the class names to make it compatible) for demo pages and replacing alert() calls with dismissible alerts.

@jzelenkov
Copy link
Contributor Author

@rodneyrehm What should happen for this pull request to get accepted?

rodneyrehm added a commit that referenced this pull request Nov 9, 2014
@rodneyrehm
Merge pull request #234 from jzelenkov/master
905af10 
Adding integration tests
@rodneyrehm rodneyrehm merged commit 905af10 into swisnl:master Nov 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No spec or test coverage.
2 participants
@jzelenkov @rodneyrehm