Refactored to use php-http/httpplug #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st/index.html) instead of Guzzle so the library doesn't depend on a specific http client implementation. This does change how you customize the ServiceProvider, just include an adapter for the client you want to use and the library uses autodiscovery (http://docs.php-http.org/en/latest/discovery.html) to find the correct adapter/client (http://docs.php-http.org/en/latest/clients.html). It also uses a MessageFactory for creating Requests and Response objects. So for example, if you want to use Guzzle, just `composer require php-http/guzzle6-adapter`, and all should be swell. In order to have a working mock client for testing you now need to include php-http/mock-client (http://docs.php-http.org/en/latest/clients/mock-client.html). Which is an easy way to mock requests.
JaZo
requested changes
Jan 16, 2018
src/Fixtures/FixturesClient.php
Outdated
|
|
||
| class FixturesClient extends Client | ||
| { | ||
| protected $fixtureReponseBuilder; |
composer.json
Outdated
| "illuminate/support": "5.3.*|5.4.*|5.5.*" | ||
| "php-http/client-implementation": "^1.0", | ||
| "php-http/discovery": "^1.0" | ||
|
|
| use Swis\JsonApi\Fixtures\FixtureResponseBuilder as BaseFixtureResponseBuilder; | ||
| use Swis\JsonApi\Fixtures\FixtureResponseBuilderInterface; | ||
|
|
||
| class FixtureResponseBuilder extends BaseFixtureResponseBuilder implements FixtureResponseBuilderInterface |
There was a problem hiding this comment.
The interface is already in BaseFixtureResponseBuilder
src/ServiceProvider.php
Outdated
| config('jsonapi.base_uri'), | ||
| new RequestFactory(), | ||
| new ResponseFactory() | ||
| MessageFactoryDiscovery::find() |
There was a problem hiding this comment.
I would move this to a function so the MessageFactory can easily be swapped without having to overwrite the entire registerApiClients method
…n since base class already implements the interface.
…xtureResponseBuilder".
JaZo
approved these changes
Jan 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored to use php-http/httpplug (http://docs.php-http.org/en/latest/index.html) instead of Guzzle so the library doesn't depend on a specific http client implementation.
This does change how you customize the ServiceProvider, just include an adapter for the client you want to use and the library uses autodiscovery (http://docs.php-http.org/en/latest/discovery.html) to find the correct adapter/client (http://docs.php-http.org/en/latest/clients.html). It also uses a MessageFactory for creating Requests and Response objects.
So for example, if you want to use Guzzle, just
composer require php-http/guzzle6-adapter, and all should be swell.In order to have a working mock client for testing you now need to include php-http/mock-client (http://docs.php-http.org/en/latest/clients/mock-client.html). Which is an easy way to mock requests.