Skip to content

Remove EloquentItem and NullItem and rename JenssegersItem #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 14, 2018

Conversation

JaZo
Copy link
Member

@JaZo JaZo commented Jul 25, 2018

Description

I removed EloquentItem and NullItem and renamed/moved Items\JenssegersItem to Item.

Motivation and context

The EloquentItem was experimental, but it had some limitations which could not be fixed without being too opinionated. Besides, no one was using it. Because of this, I decided to remove it. NullItem was used only internally and I refactored it to null. This left us with only JenssegersItem so I renamed/moved that to just Item to clean up. In the process I changed some classes that depended on the JenssegersItem instead of the ItemInterface.

How has this been tested?

Run unit tests to confirm everything still works.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@JaZo JaZo requested a review from bbrala July 25, 2018 13:49
@JaZo JaZo merged commit bbe7aff into master Aug 14, 2018
@JaZo JaZo deleted the cleanup-items branch August 15, 2018 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant