Remove EloquentItem and NullItem and rename JenssegersItem #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I removed
EloquentItem
andNullItem
and renamed/movedItems\JenssegersItem
toItem
.Motivation and context
The
EloquentItem
was experimental, but it had some limitations which could not be fixed without being too opinionated. Besides, no one was using it. Because of this, I decided to remove it.NullItem
was used only internally and I refactored it tonull
. This left us with onlyJenssegersItem
so I renamed/moved that to justItem
to clean up. In the process I changed some classes that depended on theJenssegersItem
instead of theItemInterface
.How has this been tested?
Run unit tests to confirm everything still works.
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
Go over all the following points, and put an
x
in all the boxes that apply.