Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internet-header): add aria-label on skiplinks ul element #1402

Merged

Conversation

oliverschuerch
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 12, 2023

🦋 Changeset detected

Latest commit: de4fbf0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@swisspost/internet-header Patch
@swisspost/design-system-documentation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented May 12, 2023

Preview environment ready: https://preview-1402--swisspost-design-system-next.netlify.app

Copy link
Contributor

@alizedebray alizedebray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the current Post Portal and the title "Navigieren auf post.ch" is used for the whole header:
image

While in you solution it is used for skip links only:
image

…ment to the main component as title for the hole header
@oliverschuerch oliverschuerch force-pushed the fix/1358-add-aria-label-for-quick-links-in-internet-header branch from 08b07e4 to de4fbf0 Compare May 16, 2023 15:03
@sonarcloud
Copy link

sonarcloud bot commented May 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@oliverschuerch oliverschuerch merged commit f531abb into main May 17, 2023
@oliverschuerch oliverschuerch deleted the fix/1358-add-aria-label-for-quick-links-in-internet-header branch May 17, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add aria-label for quick-links in internet-header
3 participants