-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to the last Karma version and upgrade the Node version #603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wait with merging until we got feedback from @hiddenalpha because we don't use the hook-js module.
I did ping co-workers which are able to judge "karma/npm" stuff. |
} | ||
} | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were commits for another PR. They are removed again.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #603 +/- ##
=============================================
- Coverage 48.84% 48.79% -0.05%
Complexity 1877 1877
=============================================
Files 238 238
Lines 11931 11953 +22
Branches 1259 1261 +2
=============================================
+ Hits 5828 5833 +5
- Misses 5598 5616 +18
+ Partials 505 504 -1 ☔ View full report in Codecov by Sentry. |
Can you ping them again? :-) |
No description provided.