Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to the last Karma version and upgrade the Node version #603

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

steniobhz
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@mcweba mcweba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wait with merging until we got feedback from @hiddenalpha because we don't use the hook-js module.

@hiddenalpha
Copy link
Member

We wait with merging until we got feedback from @hiddenalpha because we don't use the hook-js module.

I did ping co-workers which are able to judge "karma/npm" stuff.

}
}
]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were commits for another PR. They are removed again.

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.79%. Comparing base (9c94da6) to head (5256fe4).
Report is 54 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #603      +/-   ##
=============================================
- Coverage      48.84%   48.79%   -0.05%     
  Complexity      1877     1877              
=============================================
  Files            238      238              
  Lines          11931    11953      +22     
  Branches        1259     1261       +2     
=============================================
+ Hits            5828     5833       +5     
- Misses          5598     5616      +18     
+ Partials         505      504       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcweba
Copy link
Collaborator

mcweba commented Aug 13, 2024

We wait with merging until we got feedback from @hiddenalpha because we don't use the hook-js module.

I did ping co-workers which are able to judge "karma/npm" stuff.

Can you ping them again? :-)

@mcweba mcweba merged commit 787cc1c into develop Aug 14, 2024
6 checks passed
@mcweba mcweba deleted the feature/451_upgradedKarmaAndNode branch August 14, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants