Add several drawing functions with documentation and examples #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The deletions in imgui/core.pyx are just because I reordered the drawing functions to match the order in imgui |
|
This is rad! Thank you for the contribution. Sorry it took me so long to review. |
|
Great that it got merged! Together with the other recent updates, this will enable me to throw away my fork and publish a project on pypi. Thanks :) |
|
Great to hear that. As soon as the build completes I will publish new version. |
|
This has been released in 1.1.0 and is available for download from PyPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several functions from the raw drawing API:
AddCircle,AddCircleFilled,AddText,AddImage, andAddPolyline. All of these are members of_DrawList, which I added to documentation.Each of the newly-implemented functions have visual examples, and I tried my best to document them similarly to other functions in PyImGui. I didn't know if I should include the visual examples themselves, so I did.
This PR is a continuation of #103, but I added visual examples and limited the focus on
_DrawListfunctions. It partly intersects with #123, but with (hopefully) better documentation. It also (partly?) solves #49.