Skip to content

Max request settings fix #2808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 3, 2019
Merged

Max request settings fix #2808

merged 2 commits into from
Sep 3, 2019

Conversation

sshymko
Copy link
Contributor

@sshymko sshymko commented Sep 3, 2019

  • Fix event worker settings having no effect
  • Fix task worker settings mistakenly applying to event workers
  • Cover max_request and max_request_grace settings with tests

@sshymko
Fix max_request of event workers
27f52b1 
- Fix task worker settings applying to event workers
@sshymko
Test max_request/max_request_grace settings
8467299 
- Cover settings `max_request` and `max_request_grace` with tests
sshymko referenced this pull request Sep 3, 2019
@matyhtf
add swProcessPool_set_max_request
21d82a3
@matyhtf matyhtf merged commit 1b727fc into swoole:master Sep 3, 2019
@sshymko
Copy link
Contributor Author

sshymko commented Sep 3, 2019

@matyhtf
Oh, you merged the PR so quickly. I was going to work on it a bit more to achieve passing tests. Let me create another PR fixing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sshymko @matyhtf