Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ros1 bridge #32

Merged

Conversation

Andrew-Palmer
Copy link

This adds the mapping file necessary for ros1_bridge to be able to read GPSFix and GPSStatus messages from ROS1 bags. The ros1_bridge must be built locally.

Copy link

@pjreed pjreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks good! Sorry for taking a while to look at it, I've been swamped lately.

Only comment is that there's no need to manually increment the version number; the catkin_prepare_release script does that automatically (as well as naming the section in CHANGELOG.rst) when actually submitting a new release.

gps_msgs/CHANGELOG.rst Outdated Show resolved Hide resolved
gps_msgs/package.xml Outdated Show resolved Hide resolved
Andrew-Palmer and others added 2 commits August 14, 2020 21:39
Co-authored-by: P. J. Reed <pjreed@users.noreply.github.com>
Co-authored-by: P. J. Reed <pjreed@users.noreply.github.com>
@Andrew-Palmer
Copy link
Author

Thanks, I've accepted your suggested changes.

@pjreed pjreed merged commit 71bc033 into swri-robotics:dashing-devel Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants