Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tile_map: Maps not reliably loading #421

Closed
jhoare opened this issue Aug 24, 2016 · 2 comments
Closed

tile_map: Maps not reliably loading #421

jhoare opened this issue Aug 24, 2016 · 2 comments

Comments

@jhoare
Copy link

jhoare commented Aug 24, 2016

When attempting to load mapviz using a tile_map, it does not load every square of the map. Sometimes all (or at least most) of the squares will load, but most of the time it is very patchy and it seems like it has given up loading.

I do sometimes get a "Too Many Failures.." message to the console, but I often don't get any errors printed to the console.

I'm mostly working with the Bing Maps source but i seem to get similar results with the stamen sources as well.

I wonder if this too is related to my 4k display, and so maybe many more tiles are being requested than you guys work with?

@pjreed
Copy link
Contributor

pjreed commented Aug 24, 2016

I think this is the same as #342.

I don't think this is specifically because of a 4k display, but it may exacerbate the problem. Basically, when it tries to load a lot of tiles at once, some of the HTTP requests may time out or fail, and currently the tile_map plugin doesn't retry failed connections; it really should.

pjreed added a commit to pjreed/mapviz that referenced this issue Aug 26, 2016
This changes how the tile_map plugin handles making network requires for tiles.
It will now:
- Use thread conditions to prompt loading rather than spinning
- Prioritize loading tiles in the visible area
- Retry a failed network request up to 5 times
- Not discard tile requests if there are more than 100 in the queue

This changes should significantly reduce (if not completely eliminate) the
number of tiles that fail to load and hopefully make tiles within the visible
area appear faster when there are many in the queue.

Fixes swri-robotics#342 and swri-robotics#421.
pjreed added a commit to pjreed/mapviz that referenced this issue Sep 12, 2016
This changes how the tile_map plugin handles making network requires for tiles.
It will now:
- Use thread conditions to prompt loading rather than spinning
- Prioritize loading tiles in the visible area
- Retry a failed network request up to 5 times
- Not discard tile requests if there are more than 100 in the queue

This changes should significantly reduce (if not completely eliminate) the
number of tiles that fail to load and hopefully make tiles within the visible
area appear faster when there are many in the queue.

Fixes swri-robotics#342 and swri-robotics#421.
pjreed added a commit to pjreed/mapviz that referenced this issue Sep 12, 2016
This changes how the tile_map plugin handles making network requires for tiles.
It will now:
- Use thread conditions to prompt loading rather than spinning
- Prioritize loading tiles in the visible area
- Retry a failed network request up to 5 times
- Not discard tile requests if there are more than 100 in the queue

This changes should significantly reduce (if not completely eliminate) the
number of tiles that fail to load and hopefully make tiles within the visible
area appear faster when there are many in the queue.

Fixes swri-robotics#342 and swri-robotics#421.
pjreed added a commit to pjreed/mapviz that referenced this issue Sep 12, 2016
This changes how the tile_map plugin handles making network requires for tiles.
It will now:
- Use thread conditions to prompt loading rather than spinning
- Prioritize loading tiles in the visible area
- Retry a failed network request up to 5 times
- Not discard tile requests if there are more than 100 in the queue

This changes should significantly reduce (if not completely eliminate) the
number of tiles that fail to load and hopefully make tiles within the visible
area appear faster when there are many in the queue.

Fixes swri-robotics#342 and swri-robotics#421.
@pjreed
Copy link
Contributor

pjreed commented Sep 30, 2016

Closing since this was fixed in #423.

@pjreed pjreed closed this as completed Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants