Rewrite tile_map loading to be more reliable #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes how the tile_map plugin handles making network requires for tiles. It will now: - Use thread conditions to prompt loading rather than spinning - Prioritize loading tiles in the visible area - Retry a failed network request up to 5 times - Not discard tile requests if there are more than 100 in the queue This changes should significantly reduce (if not completely eliminate) the number of tiles that fail to load and hopefully make tiles within the visible area appear faster when there are many in the queue. Fixes swri-robotics#342 and swri-robotics#421.
|
Thanks! Anecdotally, it seems like it takes a while to start displaying images, but playing around it looks like everything does load, which is a big improvement! |
|
Yeah, it does seem like it can take a little longer to initially display tiles. It could probably stand some more improvement, but this is enough better that I'll go ahead and merge it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how the tile_map plugin handles making network requires for tiles.
It will now:
These changes should significantly reduce (if not completely eliminate) the
number of tiles that fail to load and hopefully make tiles within the visible
area appear faster when there are many in the queue.
Fixes #342 and #421.