-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create page: How to Create a Minimal Reproduction #170
Conversation
✅ Deploy Preview for splendorous-kataifi-9ae281 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
@hirasso The astro example is great! I was thinking of creating a |
We also need to make sure the existing templates on Replit and CodeSandbox actually use the current major version of swup and plugins. |
@hirasso Could you update the CodeSandbox template to use swup 4? If it's possible — I remember there being an issue since we started using export maps in |
👍 I'll try to update CodeSandbox to swup 4. Today I stumbled upon this blog post by Anthony Fu: Why Reproductions are Required. Very clear and concise in my opinion! Closing issues/discussions temporarily until they receive a minimal reproduction as outlined in the post seems to me like a very promising approach. We could also think about copying some of the blog post (for example the quote about what OSS is) in our docs page. What do you think @daun? I also like this part a lot:
|
Damnit, I accidentally deleted the swup 3 sandbox. But oh well, here's a working version with swup 4: https://codesandbox.io/p/devbox/swup-4-minimal-reproduction-template-n6kgnp |
@hirasso Feel free to merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
This is an attempt to make discussions and issue reports more pleasant for maintainers. There's been a few discussions recently where a link to this would have come in handy, so I figured I'd just create it.
Description
Preview
Link to page in deploy preview: How to Create a Minimal Reproduction
Terminology
To-do
Checks
master
branchnpm run lint
)npm run test
)