Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create page: How to Create a Minimal Reproduction #170

Merged
merged 12 commits into from
Nov 28, 2023
Merged

Conversation

daun
Copy link
Member

@daun daun commented Nov 27, 2023

This is an attempt to make discussions and issue reports more pleasant for maintainers. There's been a few discussions recently where a link to this would have come in handy, so I figured I'd just create it.

Description

  • Add a page about minimal reproductions we can link to
  • Explain why we ask for them in issue reports and help requests
  • Summarize the advantages for maintainers and consumers
  • Describe how and where to create one
  • Not listed in navigation, only meant to be linked to directly

Preview

Link to page in deploy preview: How to Create a Minimal Reproduction

Terminology

  • After lots of googling, the term "minimal reproduction" seems to be more common and widely understood
  • I also like that "minimal" is already in the title, naming both key concepts: minimal + reproducible
  • I've added "reproducible test case" to the intro as well, in case of ambiguity

To-do

Checks

  • The PR is submitted to the master branch
  • The code was linted before pushing (npm run lint)
  • All tests are passing (npm run test)

Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for splendorous-kataifi-9ae281 ready!

Name Link
🔨 Latest commit 8293afc
🔍 Latest deploy log https://app.netlify.com/sites/splendorous-kataifi-9ae281/deploys/6565d0cbea07800008596149
😎 Deploy Preview https://deploy-preview-170--splendorous-kataifi-9ae281.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@daun daun requested a review from a team November 27, 2023 17:28
Copy link
Member

@hirasso hirasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

src/docs/other/minimal-reproduction.md Outdated Show resolved Hide resolved
src/docs/other/minimal-reproduction.md Outdated Show resolved Hide resolved
src/docs/other/minimal-reproduction.md Outdated Show resolved Hide resolved
@hirasso
Copy link
Member

hirasso commented Nov 27, 2023

We could then link to this page from our issue/discussion templates. That's how astro is doing it (link "Read our guide"):

CleanShot 2023-11-27 at 19 42 32@2x

@daun
Copy link
Member Author

daun commented Nov 27, 2023

@hirasso The astro example is great! I was thinking of creating a create-swup repo so that npm create swup would work as a starting point for minimal reproductions on GitHub, but I'd rather not encourage GitHub repos we need to check out. Better to stick with online IDEs, in my opinion.

@daun
Copy link
Member Author

daun commented Nov 27, 2023

We also need to make sure the existing templates on Replit and CodeSandbox actually use the current major version of swup and plugins.

@daun
Copy link
Member Author

daun commented Nov 27, 2023

@hirasso Could you update the CodeSandbox template to use swup 4? If it's possible — I remember there being an issue since we started using export maps in package.json. It's in your account, from what it looks like. I'll take care of the Replit template.

@hirasso
Copy link
Member

hirasso commented Nov 28, 2023

👍 I'll try to update CodeSandbox to swup 4.

Today I stumbled upon this blog post by Anthony Fu: Why Reproductions are Required. Very clear and concise in my opinion! Closing issues/discussions temporarily until they receive a minimal reproduction as outlined in the post seems to me like a very promising approach. We could also think about copying some of the blog post (for example the quote about what OSS is) in our docs page. What do you think @daun?

I also like this part a lot:

In my opinion, asking for minimal reproduction is asking for equity of the effort spent.

@hirasso
Copy link
Member

hirasso commented Nov 28, 2023

Damnit, I accidentally deleted the swup 3 sandbox. But oh well, here's a working version with swup 4:

https://codesandbox.io/p/devbox/swup-4-minimal-reproduction-template-n6kgnp

@daun daun requested a review from hirasso November 28, 2023 11:44
@daun
Copy link
Member Author

daun commented Nov 28, 2023

@hirasso Feel free to merge :)

Copy link
Member

@hirasso hirasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@hirasso hirasso merged commit e8cd017 into master Nov 28, 2023
5 checks passed
@hirasso hirasso deleted the feat/test-case branch November 28, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants