Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove linked dependency from examples #139

Merged
merged 5 commits into from
Jan 17, 2023
Merged

fix: Remove linked dependency from examples #139

merged 5 commits into from
Jan 17, 2023

Conversation

enemycnt
Copy link
Contributor

@enemycnt enemycnt commented Jan 10, 2023 •
edited
Loading

Description

Related Issue Or Context

Closes: #130

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@enemycnt enemycnt changed the title Remove linked dependency from examples fix: Remove linked dependency from examples Jan 10, 2023
@enemycnt enemycnt requested a review from wainola January 10, 2023 12:47
@enemycnt enemycnt mentioned this pull request Jan 10, 2023
Merged
9 tasks
BeroBurny
BeroBurny requested changes Jan 11, 2023
View reviewed changes
examples/erc20-react-example/package.json Outdated Show resolved Hide resolved
examples/erc20-react-example/src/App.tsx Show resolved Hide resolved
examples/erc20-react-example/src/App.tsx Outdated Show resolved Hide resolved
examples/erc20-react-example/src/reportWebVitals.ts Outdated Show resolved Hide resolved
examples/erc721-react-example/src/reportWebVitals.ts Outdated Show resolved Hide resolved
wainola
wainola previously approved these changes Jan 12, 2023
View reviewed changes
@enemycnt enemycnt force-pushed the fix/examples-linked-depedency branch from 2e5bc9b to 5b6521e Compare January 16, 2023 14:40
wainola
wainola previously approved these changes Jan 17, 2023
View reviewed changes
BeroBurny
BeroBurny previously requested changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@BeroBurny BeroBurny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but fix CI issues

@enemycnt enemycnt dismissed BeroBurny’s stale review January 17, 2023 13:39

Linter CI errors were fixed

@enemycnt enemycnt requested a review from wainola January 17, 2023 13:39
@enemycnt enemycnt merged commit 430f1b5 into main Jan 17, 2023
@enemycnt enemycnt deleted the fix/examples-linked-depedency branch January 17, 2023 13:40
@github-actions github-actions bot mentioned this pull request Jan 17, 2023
Merged
@enemycnt enemycnt mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wainola wainola wainola approved these changes

@BeroBurny BeroBurny BeroBurny left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove linked dependency from examples
3 participants
@enemycnt @BeroBurny @wainola