Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orgmode H and L mapping should be removed #4645

Closed
maxigit opened this issue Jan 17, 2016 · 8 comments
Closed

orgmode H and L mapping should be removed #4645

maxigit opened this issue Jan 17, 2016 · 8 comments

Comments

@maxigit
Copy link
Contributor

maxigit commented Jan 17, 2016

In orgmode H and L are mapped to start and end of line.
This conflict with normal vim behavior (and therefore other mode) where H and L go at the top and bottom of the page.
Moreover, these mapping are unnecessary as the same can already by achieved with ^,0 and $.
Unless I'm missing something ...

@tboby
Copy link
Contributor

tboby commented Jan 17, 2016

Perhaps it's a frequency thing? I find it's really important to use org-beginning-of-line and org-end-of-line before code motion/structure editing in orgmode. $ and ^ aren't particularly comfortable to use and I go to beginning and end of line far more than beginning and end of the buffer.

Something like avy is better for moving around the current window isn't it?

@maxigit
Copy link
Contributor Author

maxigit commented Jan 17, 2016

Why do you go at the beginning and line for ? If it's to edit the line,
then just use A and I.
Anyway, I'm sure you have your reason, I just think having that as a
default is a not good thing as it breaks existing key-binding.
If you really need those mapping can't you just set them in your
configuration file ?

On 17 January 2016 at 14:40, tboby notifications@github.com wrote:

Perhaps it's a frequency thing? I find it's really important to use
org-beginning-of-line and org-end-of-line before code motion/structure
editing in orgmode. $ and ^ aren't particularly easy to use and I go to
beginning and end of line far more than beginning and end of document.


Reply to this email directly or view it on GitHub
#4645 (comment)
.

@tboby
Copy link
Contributor

tboby commented Jan 17, 2016

I didn't set the bindings, I'm just speculating.

Because org end of line and visual character end of line are not the same. In evil-org-mode it's probably more important that org-mode works properly with default keybinds.

@maxigit
Copy link
Contributor Author

maxigit commented Jan 17, 2016

I understand that the begining and end of line needs to be tweaked for
orgmode which is why ^ and $ are already set to org-beginning-of-line
and org-end-of-line. I don't think there is a need to double it up to H
and L.
(If people feel the need to map H and L to ^ and $ then they should feel it
not only for orgmode but every mode and set it in their personal
preferences).

On 17 January 2016 at 20:21, tboby notifications@github.com wrote:

I didn't set the bindings, I'm just speculating.

Because org end of line and visual character end of line are not the same.
In evil-org-mode it's probably more important that org-mode works properly
with default keybinds.


Reply to this email directly or view it on GitHub
#4645 (comment)
.

@TheBB
Copy link
Collaborator

TheBB commented Jan 19, 2016

I tend to agree with @maxigit. However I don't see that 0, ^ and $ are rebound to anything org-specific. If we can do that I'm all for removing H and L.

@what-the-functor
Copy link
Contributor

evil-org-mode provides the following bindings:
’$’ org-end-of-line
’^’ org-beginning-of-line

@choppsv1
Copy link
Contributor

+1. "H" and "L" have specific vi motions that I (and presumably many other vi users) are quite used to and aren't anywhere near beginning of line or end of line, they are top of window and bottom of window. Remapping these to motions that already have keys associated with them seems like a user specific mapping by the package author, who must not normally use H and L. We should remove these odd remappings in spacemacs and be true to vi.

choppsv1 added a commit to choppsv1/spacemacs that referenced this issue Feb 16, 2016
@jb55
Copy link
Contributor

jb55 commented Feb 16, 2016

Yeah he even went further and rebound J and K awhile back which we reverted. This seem like the author's personal bindings creeping into his library. 👍 for remove.

syl20bnr pushed a commit that referenced this issue Feb 17, 2016
zv added a commit to zv/spacemacs that referenced this issue Feb 19, 2016
* checkversion/master: (87 commits)
  cider: yet another missed occurrence
  Simplify ISSUE_TEMPLATE formatting
  Bump version to 0.105.10 and update change log
  Require use-package before using it when SPC q D
  Add restart-emacs functions for debugging
  Add .github/ISSUE_TEMPLATE
  Disable company-quickhelp-mode only when it is already enabled
  Remove url cache from .gitignore
  Add files used by eww to .gitignore.
  Move eshell cache directory and remove duplicate code for url cache
  Fix wakatime-dashboard url
  added name "preview" to p-prefix
  Rephrase note about Ubuntu package repos
  README: update docs for getting emacs on Ubuntu
  README: remove trailing whitespace
  fix renamed cider-test-run-tests function
  achievement: 6k star
  Add anaconda-eldoc-mode
  Remove H and L remap (fixes syl20bnr#4645)
  Fix toggle-maximize-buffer
  ...
posva pushed a commit to posva/spacemacs that referenced this issue Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants