-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe variable fails due to missing definition of "helm-bookmark-map" on develop #9549
Comments
There's a PR: Fix helm-bookmark initialization #9547 |
Thanks for telling me, didn't see that. Lets hope this gets merged fast. |
Pinning helm to melpa stable seems to work on develop:
|
Thanks for the tip bjarkevad but it doesn't work for me. |
@jajpater: Did you remove |
Thanks @bjarkevad That solved it! |
Should be fixed in f221d7e, can you please verify? |
@bmag Confirmed, |
@bmag I can also verify that your fix worked, on latest develop I can |
Yep it works. Issue can be closed. |
If there are any users of master branch who suffer this error: calling |
Workaround confirmed to work. Stable setup: Emacs 24.5.1, Spacemacs 0.200.9 (master) |
This seems to be a big enough issue, that a hotfix might be needed for the master branch.
Save a new buffer: Switch branch in a magit buffer: Some gitter comments also mentioned these: Syncing layers
Copy a file: Rename a file:
System Info 💻
(autohotkey auto-completion colors emacs-lisp git helm markdown org version-control)
|
Any news on this? Today I innocently ran "Update Packages" and now Spacemacs is unusable for cider-repl loading (C-c C-l) due to “Symbol’s value as variable is void: helm-bookmark-map”. I tried adding the melpa stable fix and reloading helm but I still get the same error. Latest Spacemacs 0.200.9@25.2.1 |
@garyheath Currently, the simplest solution is, as stated in the earlier comment by bmag. Add this command: |
Hi Duianto
Thanks. That worked. Was fixated on the other suggestions and missed
this one.
Gary
…On 09/09/2017 16:26, duianto wrote:
@garyheath <https://github.com/garyheath> Currently, the simplest
solution is, as stated in the earlier comment by bmag
<#9549 (comment)>.
Add this command: |(require 'helm-bookmark)| to the
|dotspacemacs/user-config()| section in your |.spacemacs| file. Then
restart Emacs and the |helm-bookmark-map| message will go away.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9549 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ASWmPJVCQG2-2q3Sv_D2-xUT6nvl3BAXks5sgq4vgaJpZM4PO-lj>.
|
Yes, we are aware. syl20bnr is planning to make a hot fix release soon (I don't know exactly when, but hopefully within several days) |
Reopening for visibility. The issue will be closed in the next release. |
Fixed in develop? Will it take long to merge develop into master? 😹 |
I had the same problem when trying to switch branch with magit. Adding |
Chiming in as another person on master, updated packages after a while, and hit this bug. I'm curious what the status of fixing master is. |
Please fix this. It's breaking my workflow. |
@macalinao The problem is known and fixed in the develop branch, no need to add messages which could be replaced by upvoting the issue or some of latest comments. (because they dilute the messages related to how to fix the issue and release the fix) Someone correct me if I'm wrong, but the best thing to do to recover the functionality + helping to ship it would be to switch on the develop branch and report eventual bugs (or just enjoy the fix). So the next release will come sooner. |
A newbie just posted on Gitter about this bug. The fix is trivial for those whom are used to Spacemacs. However this bug has the potential to make a bad impression on new users. It has been over a month since it was determined that there should be a hotfix. What's holding up the hot fix? Anything I can do to help? |
That's a good point. The bug can be fixed easily...if one has ever had
experience with Emacs.
If I had seen this error 2 months ago, as a newbie, I'd have thought "well,
this doesn't work", and probably switched to Atom or Sublime.
|
As I see that many of you are getting pretty frustrated with the state on master please consider: To be honest currently we have more issues then we have hands to fix. Therefore everybody focus on develop rather than on the old master. Speaking of hands ... you know spacemacs is community driven, that means we expect and need our users to get involved in the project. So if you like spacemacs please consider Consider the more stuff we contributors fix the more time the colaborators have for making hotfixes and working on the core. And this is what you guys are all waiting for. So please get involved. |
Good points @smile13241324. We're all developers here, and I assume we all have a good understanding of what 'hotfix' means. This bug is labelled as fixed on develop. What this tells me, is that the fix is waiting on someone to merge or cherry-pick the specific parts needed for a release. As you said this is a community driven project. The community has fixed the bug; and we are waiting on someone to do the actual release. If there is anything holding this back, please list it here so we (collectively) can contribute toward this fix. |
@syl20bnr Can you tell when you will be able to provide a hotfix for this on master? This issue seems to become pretty urgent, judging from the amount of people commenting here. Is there anything blocking you where we could help? |
Has anyone tried to backport this fix to master an check that it doesn't break anything? That's one step that the maintainer.s wouldn't have to do. |
I can prepare the hotfix and do a backport, since I am installing spacemacs on a new machine today. What is the fix's commit# in develop? |
I'm a neovim user trying out spacemacs at the moment. The issue affects go layer: most of go-guru commands do not work out of the box. Also customize-variable do not popup preference window. |
@SlightlyCyborg
It seems to be f221d7e |
Going to release a 200.10 with the hotfix. |
@syl20bnr do you mean today or in general? :) |
Planned tomorrow sorry, yesterday I worked on the signing of Spacelpa tarballs. Hum ^_^ |
Fixed in 0.200.10 🎉 |
Yup, seems to fix this issue! |
time to close this issue :) |
Fixed in both branches. |
Description![:octocat: :octocat:](https://github.githubassets.com/images/icons/emoji/octocat.png)
Since the latest update on develop every call of
SPC h d v
fails due to an undefined variablehelm-bookmark-map
.Reproduction guide 🪲
SPC h d v
and select a variable of your choiceObserved behaviour: 👀 💔
The symbol
helm-bookmark-map
is referenced but not defined which causes emacs to fail at displaying the variable description. A quick smart search showed me the file is referenced from the helm layer's packages.el only.Expected behaviour: ❤️ 😄
Show the description
System Info 💻
Backtrace 🐾
The text was updated successfully, but these errors were encountered: