Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug: evil-magit not initailized inside 'keyboard-layout' layer #10148

Closed
wants to merge 1 commit into from
Closed

Fix bug: evil-magit not initailized inside 'keyboard-layout' layer #10148

wants to merge 1 commit into from

Conversation

ACEMerlin
Copy link

@ACEMerlin ACEMerlin commented Jan 13, 2018 •
edited
Loading

The Issue: #10133

@syl20bnr
Copy link
Owner

I think we should split the configuration into magit and evil-magit. With the current proposal people in holy mode won't get the correct keybindings as evil-magit is not initialized at all for them.

@syl20bnr syl20bnr added Merged and removed Merged labels Jan 17, 2018
@nixmaniack nixmaniack mentioned this pull request Jan 24, 2018
Closed
@ACEMerlin
Copy link
Author

not sure how to fix this. FYI evil-magit initialized 2 times inside git layer, seems a bit redundant.

@ACEMerlin ACEMerlin closed this Jan 26, 2018
@nixmaniack
Copy link
Contributor

@ACEMerlin Where do you see evil-magit initialized twice? Could you point to the code?

@Electron-libre
Copy link

Don't understand why is this closed. It's not merged in develop and this issue is not fixed.

@nixmaniack
Copy link
Contributor

not sure how to fix this

perhaps because of this @Electron-libre. Help needed in short!

StreakyCobra added a commit to StreakyCobra/spacemacs that referenced this pull request Feb 10, 2018
@StreakyCobra
[keyboard-layout] Split evil-magit and magit configurations
a2fcdb8 
Fix syl20bnr#10133 and syl20bnr#10229, supersede syl20bnr#10148
Modification as suggested in [1].

[1] syl20bnr#10148 (comment)
@StreakyCobra StreakyCobra mentioned this pull request Feb 10, 2018
Closed
StreakyCobra added a commit to StreakyCobra/spacemacs that referenced this pull request Feb 17, 2018
@StreakyCobra
[keyboard-layout] Split evil-magit and magit configurations
a5f7ccd 
Fix syl20bnr#10133 and syl20bnr#10229, supersede syl20bnr#10148
Modification as suggested in [1].

[1] syl20bnr#10148 (comment)
StreakyCobra added a commit to StreakyCobra/spacemacs that referenced this pull request Feb 19, 2018
@StreakyCobra
[keyboard-layout] Split evil-magit and magit configurations
2960795 
Fix syl20bnr#10133 and syl20bnr#10229, supersede syl20bnr#10148
Modification as suggested in [1].

[1] syl20bnr#10148 (comment)
StreakyCobra added a commit to StreakyCobra/spacemacs that referenced this pull request Feb 22, 2018
@StreakyCobra
[keyboard-layout] Split evil-magit and magit configurations
9f5a475 
Fix syl20bnr#10133 and syl20bnr#10229, supersede syl20bnr#10148
Modification as suggested in [1].

[1] syl20bnr#10148 (comment)
syl20bnr pushed a commit that referenced this pull request Feb 25, 2018
@StreakyCobra @syl20bnr
[keyboard-layout] Split evil-magit and magit configurations
29fa494 
Fix #10133 and #10229, supersede #10148
Modification as suggested in [1].

[1] #10148 (comment)
braineo pushed a commit to braineo/spacemacs that referenced this pull request Feb 25, 2018
@StreakyCobra @braineo
[keyboard-layout] Split evil-magit and magit configurations
2d3c950 
Fix syl20bnr#10133 and syl20bnr#10229, supersede syl20bnr#10148
Modification as suggested in [1].

[1] syl20bnr#10148 (comment)
pinetr2e pushed a commit to pinetr2e/spacemacs that referenced this pull request Mar 7, 2018
@StreakyCobra @pinetr2e
[keyboard-layout] Split evil-magit and magit configurations
25b8c60 
Fix syl20bnr#10133 and syl20bnr#10229, supersede syl20bnr#10148
Modification as suggested in [1].

[1] syl20bnr#10148 (comment)
ztlevi pushed a commit to ztlevi/spacemacs that referenced this pull request Apr 26, 2018
@StreakyCobra @ztlevi
[keyboard-layout] Split evil-magit and magit configurations
11dfd61 
Fix syl20bnr#10133 and syl20bnr#10229, supersede syl20bnr#10148
Modification as suggested in [1].

[1] syl20bnr#10148 (comment)
alanjferguson pushed a commit to alanjferguson/spacemacs that referenced this pull request May 14, 2018
@StreakyCobra
[keyboard-layout] Split evil-magit and magit configurations
14bf616 
Fix syl20bnr#10133 and syl20bnr#10229, supersede syl20bnr#10148
Modification as suggested in [1].

[1] syl20bnr#10148 (comment)
buckarooch pushed a commit to profilech/.emacs.d that referenced this pull request May 19, 2018
@StreakyCobra @buckarooch
[keyboard-layout] Split evil-magit and magit configurations
7ebe894 
Fix syl20bnr#10133 and syl20bnr#10229, supersede syl20bnr#10148
Modification as suggested in [1].

[1] syl20bnr#10148 (comment)
gdkrmr pushed a commit to gdkrmr/spacemacs that referenced this pull request Jun 26, 2018
@StreakyCobra @gdkrmr
[keyboard-layout] Split evil-magit and magit configurations
d97571d 
Fix syl20bnr#10133 and syl20bnr#10229, supersede syl20bnr#10148
Modification as suggested in [1].

[1] syl20bnr#10148 (comment)
CodingSolo pushed a commit to CodingSolo/spacemacs that referenced this pull request Oct 29, 2018
@StreakyCobra
[keyboard-layout] Split evil-magit and magit configurations
ee20753 
Fix syl20bnr#10133 and syl20bnr#10229, supersede syl20bnr#10148
Modification as suggested in [1].

[1] syl20bnr#10148 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ACEMerlin @syl20bnr @nixmaniack @Electron-libre