Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch evil-indent-textobject to a fork #2656

Closed
wants to merge 1 commit into from

Conversation

TheBB
Copy link
Collaborator

@TheBB TheBB commented Aug 14, 2015

With the shiny new quelpa, I figured I might suggest this.

evil-indent-textobject is broken, see #2326 and cofi/evil-indent-textobject#1. This switches to a fork (full disclosure, it's my fork) that fixes it. It also adds a couple of indentation-related text objects that the previous package doesn't have.

@TheBB
Copy link
Collaborator Author

TheBB commented Aug 14, 2015

In this fork, lines that are either empty or have a higher indentation will be considered part of the text object. In the stock package, these lines interrupt the text object. See examples in #2326.

The new text objects are:

  • ii: lines with equal or higher indentation.
  • iI: ii plus the preceding line with lower indentation. (Useful in e.g. Python.)
  • iJ: iI plus the succeeding line with lower indentation.

as well as a versions of each, which include whitespace.

@syl20bnr
Copy link
Owner

Wonderful, just tried them and they work flawlessly 👍
Thank you!
I pushed the change for recipe inlining in commit 437a819

Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Aug 14, 2015
@TheBB TheBB deleted the fix-2326 branch August 14, 2015 19:59
@Kethku
Copy link
Contributor

Kethku commented Aug 14, 2015

I just cloned spacemacs on my surface and switched to the develop branch 10 minutes ago. I am now getting an error on startup:

Found 1 new package(s) to install...
--> fetching new package repository indexes...
--> installing spacemacs:evil-indent-textobject... [1/1]An error occurred while installing evil-indent-textobject (error: (wrong-type-argument arrayp nil))

I think it has something to do with this pull request. Not sure though

@syl20bnr
Copy link
Owner

Can you provide the stack ? (emacs ---debug-init)

@Kethku
Copy link
Contributor

Kethku commented Aug 14, 2015

That feel when I don't know how to copy things in non evilified emacs... Give me a sec

@Kethku
Copy link
Contributor

Kethku commented Aug 14, 2015

I don't know if this will be helpful...

https://gist.github.com/Devagamster/edf96b6cc980d528ac86

Is this what you are looking for?

@TheBB
Copy link
Collaborator Author

TheBB commented Aug 14, 2015

That looks like my problem. Give me a second.

@TheBB
Copy link
Collaborator Author

TheBB commented Aug 14, 2015

Hi, @Devagamster, I just made a clean install from latest develop with no problems, so I can't reproduce. What's your Emacs version? Maybe you can file a new issue.

@TheBB
Copy link
Collaborator Author

TheBB commented Aug 14, 2015

I found this which looks similar, but the resolution is rather cryptic....

@TheBB
Copy link
Collaborator Author

TheBB commented Aug 14, 2015

If you clone TheBB/evil-indent-textobject, open the elisp file in there and M-: (eval) (package-buffer-info), do you get the same error then?

@mahinshaw
Copy link
Contributor

I am having the same Problem on GNU Emacs 24.5.1 (x86_64-w64-mingw32) of 2015-04-12 on KAEL. I will run (package-buffer-info) and get back to you.

@TheBB
Copy link
Collaborator Author

TheBB commented Aug 18, 2015

You should probably make a new issue about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants