Add new bindings to ESS layer #4176
Conversation
andrew-christianson
force-pushed
the
ess-bindings
branch
from
a1a7f05
to
8a1e73a
Compare
layers/+lang/ess/README.org
Outdated
| Useful, IDE like functions. | ||
| | Key Binding | Description | | ||
| |-------------+--------------------------------------------------------------------------------------------| | ||
| | ~SPC m d l~ | ~(ess-developer-load-package)~ load a specified directory with ~devtools::load_all~ | |
There was a problem hiding this comment.
Please, avoid function names here. People usually far more interested in what it does 😸
|
Wow, this is an old one PR. Is it still relevant? 😸 P. S. Sorry for taking so long 😢 |
|
Spacemacs + ESS is still my daily driver @ work so it's still relevant to me :). I've been using the stock layer for a while now for convenience sake, though I'd love to come back to this and incorporate the above + resolve the conflicts if you guys would consider it. |
andrew-christianson
force-pushed
the
ess-bindings
branch
from
8a1e73a
to
53fd410
Compare
andrew-christianson
force-pushed
the
ess-bindings
branch
3 times, most recently
from
6ecad54
to
14918ff
Compare
andrew-christianson
force-pushed
the
ess-bindings
branch
3 times, most recently
from
c08c393
to
6128da8
Compare
| - [[#Developer][Developer]] | ||
| - [[#debugging][Debugging]] | ||
| - [[#help][Help]] | ||
| - [[Install][Install]] |
There was a problem hiding this comment.
Aren’t these links supposed to start with #? And if you change them to use # (and without initial capital letters) instead, you will get a smaller diff (reduced to your additions only).
I just ran ./core/tools/spacefmt/spacefmt all while on your branch, which indeed changed these lines to #. So you should probably use #.
| To use this configuration layer, add it to your =~/.spacemacs=. You will need to | ||
| add =ess= to the existing =dotspacemacs-configuration-layers= list in this | ||
| file. | ||
| To use this configuration layer, add it to your =~/.spacemacs=. You will need to |
There was a problem hiding this comment.
Spurious change. Only changes whitespace (indentation). Same for many of the hunks below this one.
|
Btw: the email addresses of your “author” and “committer” are different on one of the commits, which makes one of the commits show up as “andrew committed with andrew” on GitHub. ☺ |
andrew-christianson
force-pushed
the
ess-bindings
branch
2 times, most recently
from
da674d3
to
fc45405
Compare
andrew-christianson
force-pushed
the
ess-bindings
branch
from
fc45405
to
492250c
Compare
andrew-christianson
force-pushed
the
ess-bindings
branch
2 times, most recently
from
41d7d59
to
0f7b7a6
Compare
andrew-christianson
force-pushed
the
ess-bindings
branch
2 times, most recently
from
84dced3
to
9588536
Compare
|
R support was one of the chief reasons for me to start using Spacemacs, so very relevant to me as well! Would love to see this merged 😊 |
andrew-christianson
force-pushed
the
ess-bindings
branch
from
9588536
to
abaee25
Compare
Add new evil-leader bindings for lots of the functions behind ess-dev-map and ess-doc-map. Major additions are SPC m d for IDE-like commands (roxygen, style), SPC m b for debugger interaction, and a few extras in SPC m s and SPC m h. Also add a few new layer variables controlling the indenting style, and update README for all.
andrew-christianson
force-pushed
the
ess-bindings
branch
from
abaee25
to
d4ca6b2
Compare
|
I'd be happy to merge at least the first commit if you make the changes that have been proposed, and bring the company integration up to scratch with current Spacemacs. |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this PR is still need merging! |
Reopening #4166 with on a separate branch in my fork + resolve the merge conflict with #4150.
Commit Message:
Add new evil-leader bindings for lots of the functions behind
ess-dev-map and ess-doc-map. Major additions are SPC m d for IDE-like
commands (roxygen, style), SPC m b for debugger interaction, and a few
extras in SPC m s and SPC m h.
Also add a few new layer variables controlling the indenting style, and
update README for all.