Work around bug in eshell's preoutput-filter code. #8635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eshell doesn't call preoutput-filter functions in the context of the eshell buffer. This breaks the xterm color filtering when the eshell buffer is updated when it's not currently focused. I intend on submitting this fix upstream when I get a chance but an advice fixes it for now. The other fix is to move the xterm color filter to a output-filter function (instead of preoutput-filter) but those operate on strings that have already been inserted into the buffer.
|
Thank you ! 👍 |
|
The |
Stebalien
added a commit
to Stebalien/spacemacs
that referenced
this pull request
Apr 29, 2017
`define-advice` requires Emacs 25. Addresses: syl20bnr#8635 (comment)
syl20bnr
pushed a commit
that referenced
this pull request
May 4, 2017
`define-advice` requires Emacs 25. Addresses: #8635 (comment)
CodingSolo
pushed a commit
to CodingSolo/spacemacs
that referenced
this pull request
Oct 29, 2018
`define-advice` requires Emacs 25. Addresses: syl20bnr#8635 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eshell doesn't call preoutput-filter functions in the context of the eshell buffer. This breaks the xterm color filtering when the eshell buffer is updated when the eshell buffer is not currently focused.
I intend to submit this fix upstream when I get a chance but an advice fixes it for now. The other fix is to move the xterm color filter to a output-filter function (instead of preoutput-filter) but those operate on strings that have already been inserted into the buffer.