Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instance start --app does not execute correct startscript #2410

Closed
dtrudg opened this issue Nov 29, 2023 · 0 comments · Fixed by #2408
Closed

instance start --app does not execute correct startscript #2410

dtrudg opened this issue Nov 29, 2023 · 0 comments · Fixed by #2408
Assignees
@dtrudg
Labels
backport Backport this to stable version bug Something isn't working
Milestone
SingularityCE 4.0.3

Comments

@dtrudg
Copy link
Member

dtrudg commented Nov 29, 2023

Version of Singularity

4.x / main

Describe the bug

In #1942 the cherry-pick of %appstart support ommitted some action script code that is necessary to start the correct %appstart block when --app is specified on instance start. The generic %startscript block was always executed.

This bug was not found previously as adding an e2e test was deferred. Work to implement #1944 exposed the problem.
@dtrudg dtrudg added the bug Something isn't working label Nov 29, 2023
@dtrudg dtrudg added this to the SingularityCE 4.0.3 milestone Nov 29, 2023
@dtrudg dtrudg added the backport Backport this to stable version label Nov 29, 2023
@dtrudg dtrudg self-assigned this Nov 29, 2023
dtrudg added a commit to dtrudg/singularity that referenced this issue Nov 29, 2023
@dtrudg
fix: execute correct %appstart script with instance start --app
b216e3f 
Fixes: sylabs#2410
@dtrudg dtrudg mentioned this issue Nov 29, 2023
Merged
dtrudg added a commit to dtrudg/singularity that referenced this issue Nov 29, 2023
@dtrudg
fix: execute correct %appstart script with instance start --app
596fe35 
Fixes: sylabs#2410
dtrudg added a commit to dtrudg/singularity that referenced this issue Jan 10, 2024
@dtrudg
fix: execute correct %appstart script with instance start --app
95cbff7 
Fixes: sylabs#2410
@dtrudg dtrudg mentioned this issue Jan 10, 2024
Merged
dtrudg added a commit to dtrudg/singularity that referenced this issue Jan 10, 2024
@dtrudg
fix: execute correct %appstart script with instance start --app
de1e8e9 
Fixes: sylabs#2410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtrudg dtrudg

Labels
backport Backport this to stable version bug Something isn't working
Projects
None yet
Milestone
SingularityCE 4.0.3
Development

Successfully merging a pull request may close this issue.

fix: Execute correct %appscript and add test for instance start --app dtrudg/singularity
1 participant
@dtrudg