fix: Execute correct %appscript and add test for instance start --app (release-4.0) #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wobito
approved these changes
Jan 10, 2024
Use the same echo server pattern that's implemented for testing `instance start`, but make `%appstart foo` a string reversing echo server, so we can tell that we started the right thing. Fixes sylabs#1944
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
Pick #2408
Add an e2e test for
instance start --app. Use the same echo server pattern that's implemented for testinginstance start, but make%appstart fooa string reversing echo server, so we can tell that we started the right thing.This uncovered issue #2410 - so we also have a fix to run the correct
%appscriptinstead of the generic%startscriptforinstance start --app.This fixes or addresses the following GitHub issues:
instance start --appfunctionality #1944Before submitting a PR, make sure you have done the following:
make checkand tested this PR locally with amake test, andmake testallif possible (see CONTRIBUTING.md).