Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Execute correct %appscript and add test for instance start --app #2408

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

dtrudg
Copy link
Member

@dtrudg dtrudg commented Nov 29, 2023

Description of the Pull Request (PR):

Add an e2e test for instance start --app. Use the same echo server pattern that's implemented for testing instance start, but make %appstart foo a string reversing echo server, so we can tell that we started the right thing.

This uncovered issue #2410 - so we also have a fix to run the correct %appscript instead of the generic %startscript for instance start --app.

This fixes or addresses the following GitHub issues:

Before submitting a PR, make sure you have done the following:

Use the same echo server pattern that's implemented for testing
`instance start`, but make `%appstart foo` a string reversing echo
server, so we can tell that we started the right thing.

Fixes sylabs#1944
@dtrudg dtrudg added this to the SingularityCE 4.1.0 milestone Nov 29, 2023
@dtrudg dtrudg self-assigned this Nov 29, 2023
@dtrudg dtrudg changed the title e2e: Add test for instance start --app fix: Execute correct %appscript and add test for instance start --app Nov 29, 2023
@dtrudg dtrudg added bug Something isn't working backport Backport this to stable version labels Nov 29, 2023
@dtrudg dtrudg marked this pull request as ready for review November 29, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backport this to stable version bug Something isn't working
Projects
None yet
2 participants