-
Notifications
You must be signed in to change notification settings - Fork 57
[Elephant] Issue #189 Added SignSchema #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
evias
merged 24 commits into
symbol:master
from
rg911:task/g189_Keccak_KeyPair_Key_Derive
Jul 3, 2019
Merged
[Elephant] Issue #189 Added SignSchema #190
evias
merged 24 commits into
symbol:master
from
rg911:task/g189_Keccak_KeyPair_Key_Derive
Jul 3, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added SignSchema to make SDK compitable with NIS
Pull Request Test Coverage Report for Build 554
💛 - Coveralls |
evias
reviewed
Jun 28, 2019
Added SignSchema to make SDK compitable with NIS
…1/nem2-sdk-typescript-javascript into task/g189_Keccak_KeyPair_Key_Derive
Fixed issues in nacl_catalupt class
evias
approved these changes
Jul 3, 2019
Added SignSchema to make SDK compitable with NIS
Fixed issues in nacl_catalupt class
…1/nem2-sdk-typescript-javascript into task/g189_Keccak_KeyPair_Key_Derive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SignSchema
to make KeyPair generation consistent between Catapult and NIS.SignSchema
contain 2 enum value:KECCAK_REVERSED_KEY
andSHA3
. The SDK by default usesSHA3
which is the Catapult signature schema.Concept
Since Catapult server is using 'SHA3' as default hasher while
NIS1 (current public net)
isKeccak
based. This change will allow Catapult SDK to be compatible to NIS1's hashes e.g. KeyPair, Address, Encryption, Decryption etc..By default, the SDK uses
SignSchema.SHA3
for hashing unless explicitly specifiedKECCAK_REVERSED_KEY
.createKeyPairFromPrivateKeyString
sign
verify
deriveSharedKey
encode
decode
createFromPublicKey
createFromPublicKey
verifySignature