Skip to content

JAV-19 [Github #259 #260 #241] Various small issues fixed #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 24, 2019
Merged

JAV-19 [Github #259 #260 #241] Various small issues fixed #261

merged 3 commits into from
Sep 24, 2019

Conversation

rg911
Copy link
Contributor

@rg911 rg911 commented Sep 21, 2019 •
edited
Loading

  • Unused mosaicProperties code removed
  • Integration test fixed
  • jsdoc fixed
  • Renamed NamespaceType to RegistrationType (missed in E3 schema patch)
  • Fixed EncryptedPrivateKey cannot be instantiate issue

@coveralls
Copy link

coveralls commented Sep 21, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 677

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 69.098%
Totals Coverage Status
Change from base Build 671: 0.002%
Covered Lines: 6257
Relevant Lines: 8354
💛 - Coveralls

@rg911 rg911 changed the title JAV-19 [Github #259 #260] Removed unused mosaic properties coeds JAV-19 [Github #259 #260 #241] Various small issue fixed Sep 21, 2019
@rg911 rg911 changed the title JAV-19 [Github #259 #260 #241] Various small issue fixed JAV-19 [Github #259 #260 #241] Various small issues fixed Sep 21, 2019
fullcircle23
fullcircle23 approved these changes Sep 24, 2019
View reviewed changes
Copy link

@fullcircle23 fullcircle23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rg911 rg911 merged commit 22a744c into symbol:master Sep 24, 2019
@rg911 rg911 deleted the task/g260_remaining_mosaic_properties branch October 8, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evias evias Awaiting requested review from evias

@fboucquez fboucquez Awaiting requested review from fboucquez

1 more reviewer

@fullcircle23 fullcircle23 fullcircle23 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rg911 @coveralls @fullcircle23