Skip to content

JAV-42 & JAV-45 Metadata and MosaicRestriction endpoints implementation #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Oct 4, 2019
Merged

JAV-42 & JAV-45 Metadata and MosaicRestriction endpoints implementation #272

merged 21 commits into from
Oct 4, 2019

Conversation

rg911
Copy link
Contributor

@rg911 rg911 commented Sep 26, 2019 •
edited
Loading

  • Metadata endpoints implemented.
  • MosaicRestriction endpoints implemented.
  • Latest OpenApi generated code applied (Without MosaicRestriction)
  • Added unit and e2e tests
  • Fixed Namespace/names endpoint bug (openApi doc issue reported)

Issue: #266 #271

@coveralls
Copy link

coveralls commented Sep 26, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 710

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 699: 0.0%
Covered Lines: 10
Relevant Lines: 10
💛 - Coveralls

rg911 added 15 commits September 26, 2019 21:13
@rg911
Exported metadata models and http
a3888ab
@rg911
JAV-43 [Github: symbol#266]:
279af06 
- Added metadata http repository
- Applied latest OpenAPI generated codes
@rg911
Updated namespaceNameDTO, correct the namespaceNameHttp
f453a4a
@rg911
Added more e2e test asserts
cbe567b
@rg911
Exported metadata models and http
aee1399
@rg911
Merge branch 'task/g266_metadata_endpoints' of github.com:rg911/nem2-…
c46ae92 
…sdk-typescript-javascript into task/g266_metadata_endpoints
@rg911
Updated metadata DTO models with latest OpenApi changes
5fe1251
@rg911
Fixed a few issues on e2e tests
3af4c46
@rg911
Merge branch 'master' into task/g266_metadata_endpoints
46a482f
@rg911
Updated metadata e2e tests with string value
46274f5 
fixed metadata transaction mapper
@rg911
Fixed transactionToJson
4ac774c 
Fixed unit tests
@rg911
Fixed metadataHttp and e2e tests
7071512
@rg911
Added MosaicRestriction Http & Tests
710949d
@rg911
Applied new mosaicRestriction model
a121158 
Fixed tests
@rg911
Applied catapult-rest metadata changes.
7aa3dc4 
scopedMetadataKey in hex string format
@rg911 rg911 changed the title JAV-42 metadata endpoints implementation JAV-42 & JAV-45 Metadata and MosaicRestriction endpoints implementation Oct 1, 2019
fboucquez
fboucquez suggested changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@fboucquez fboucquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Steve, my only change would be to convert the value in Metadata to plain string inside the sdk, in the DTO mappers.

rg911 added 3 commits October 2, 2019 22:41
@rg911
Updated metadata endpoints
b18f4fb 
added decode to hex in metadata state mapper
@rg911
Fixed bug in restrictions Map
4971648
@rg911
Changed metadata transaction value to use hex
d747838 
Fixed a few issues in mosaic restriction tests
@rg911 rg911 requested a review from fboucquez October 4, 2019 13:20
@rg911 rg911 merged commit 819fcfe into symbol:master Oct 4, 2019
@rg911 rg911 deleted the task/g266_metadata_endpoints branch October 8, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fullcircle23 fullcircle23 Awaiting requested review from fullcircle23

2 more reviewers

@evias evias evias approved these changes

@fboucquez fboucquez fboucquez approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rg911 @coveralls @evias @fboucquez