Skip to content

JAV-41 Audit merkle proof receipt #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 14, 2019
Merged

JAV-41 Audit merkle proof receipt #301

merged 5 commits into from
Oct 14, 2019

Conversation

rg911
Copy link
Contributor

@rg911 rg911 commented Oct 12, 2019

  • Fixed bug in ResolutionStatement & ResolutionEntry
  • Added ResolutionType parameter in to ResolutionEntry
  • Added Receipt serializer
  • Added generateHash to generate receipt hash for merkle tree proof
  • Updated CreateReceiptFromDTO
  • Added/Fixed receipt tests

@coveralls
Copy link

coveralls commented Oct 12, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 750

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 748: 0.0%
Covered Lines: 10
Relevant Lines: 10
💛 - Coveralls

@rg911 rg911 merged commit 8348b1b into symbol:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgarcia360 dgarcia360 Awaiting requested review from dgarcia360

@fboucquez fboucquez Awaiting requested review from fboucquez

1 more reviewer

@evias evias evias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rg911 @coveralls @evias