Skip to content

Conversation

evias
Copy link
Contributor

@evias evias commented Nov 19, 2019

Changed

  • Refactor of Transaction.createTransactionHash for clarity and use protocol identical transaction creation flow as seen in TransactionExtensions

@coveralls
Copy link

coveralls commented Nov 19, 2019

Pull Request Test Coverage Report for Build 835

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 828: 0.0%
Covered Lines: 5
Relevant Lines: 5

💛 - Coveralls

@evias
Copy link
Contributor Author

evias commented Nov 20, 2019

on hold because of Keccak usage in transaction hash, maybe not necessary will update PR accordingly


return Convert.uint8ToHex(hash);
// 6) create SHA3 or Keccak hash depending on `signSchema`
const signSchema: SignSchema = SHA3Hasher.resolveSignSchema(networkType);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As gimre confirmed with me on slack, TransactionHash is always using sha3_256, I think we don't need resolving the signSchema anymore

Copy link
Contributor

@rg911 rg911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need remove the signSchema for generating TransactionHash and MerkleTransactionHash for now before we are more clear with all parties. Since the core devs confirmed that transactionHash only use sha3_256 regardless networkTypes (signSchema) at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants