Block service #450
Closed
Block service #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboucquez
suggested changes
Feb 18, 2020
Comment on lines
+78
to
+83
| if (pathItem.position === 1) { | ||
| return hasher.update(Buffer.from(pathItem.hash + proofHash, 'hex')).hex(); | ||
| } else { | ||
| // Right | ||
| return hasher.update(Buffer.from(proofHash + pathItem.hash, 'hex')).hex(); | ||
| } |
There was a problem hiding this comment.
The position is being changed from a number to a (left/right) string. Rest has done the change in master, we are still waiting for the open api PR symbol/symbol-openapi#77
@dgarcia360 can we move 77 PR forward? once released we can then generate the clients and update the ts and java PR related to merkle tests
There was a problem hiding this comment.
|
@rg911 can we add unit testing to the block service. E2E tests are great but they don't run every build and they don't increase coverage. |
dgarcia360
suggested changes
Feb 18, 2020
…sdk-typescript-javascript into task/g449_block_service
|
@rg911 0.8.4-SNAPSHOT.202002181344 client has been pushed to npm |
|
Rebased to #453 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
BlockServiceto validate transaction and receipt hashes against in specific blockFixed #449