Skip to content

useQuerystring in http client on AccountRoutesApi #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from Mar 12, 2020
Merged

useQuerystring in http client on AccountRoutesApi #494

merged 3 commits into from Mar 12, 2020

Conversation

rg911
Copy link
Contributor

@rg911 rg911 commented Mar 12, 2020

FIxed #493

@rg911 rg911 requested a review from fboucquez March 12, 2020 15:17
fboucquez
fboucquez suggested changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@fboucquez fboucquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add useQueryString to all the RoutesApi instances in all the HTTP clients

@rg911 rg911 merged commit b94fe34 into symbol:master Mar 12, 2020
@fboucquez fboucquez deleted the task/g493_use_querystring_in_tx_filter branch March 12, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@fboucquez fboucquez fboucquez approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Force sdk to use querystring with transactionFilter
2 participants
@rg911 @fboucquez