Added injectable websocket to repotFactor.createListener() #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about moving the parameters to the repository factory constructor? The clients will only have a centralised place to configure the factory ans will keep using repositoryFactory.createListener() as they used to. |
|
I was thinking this is quite specific for listener only, probably better keep in the method instead? |
- Moved optional params in RepoFactory to RepositoryFactoryConfig interface - Changed Listener to use actual ws url instead of rest url.
fboucquez
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NewBlockmodel rather than sharedBlockInfowith rest payload. So that there will be noundefinedfields in ws response.InjectedWebsocketandwebsocketUrlparameters to the repositoryFactory constructor as optional parametersListenerconstructor to useurlwithout appending/wssuffix.stateHashSubCacheMerkleRootsinBlockInfoFixed #581
Fixed #582
Fixed #584
Fixed #585