Skip to content

task: add nullish coalescing operator to handle undefine meta properties #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2022
Merged

task: add nullish coalescing operator to handle undefine meta properties #843

merged 1 commit into from
Sep 21, 2022

Conversation

AnthonyLaw
Copy link
Member

What was the issue?

  • REST is not returned timestamp and feeMultiplier in unconfirmed / partial / Listener, It caused SDK transaction DTO throw error when the value is undefined.

What's the fix?

  • added bullish coalescing operator to handle timestamp and feeMultiplier, when value is undefined, it returns 0

@AnthonyLaw AnthonyLaw linked an issue Sep 20, 2022 that may be closed by this pull request
Unable to extract transaction meta handled by listener. #841
Closed
@AnthonyLaw AnthonyLaw merged commit c5f69f5 into dev Sep 21, 2022
@AnthonyLaw AnthonyLaw deleted the fix/meta-issue-in-partial-tx branch September 21, 2022 17:22
This was referenced Oct 6, 2022
Merged
Merged
@AnthonyLaw AnthonyLaw mentioned this pull request Apr 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaguar0625 Jaguar0625 Jaguar0625 approved these changes

@gimre-xymcity gimre-xymcity Awaiting requested review from gimre-xymcity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to extract transaction meta handled by listener.
2 participants
@AnthonyLaw @Jaguar0625