Skip to content

Added #28 Listener for cosignatories -> Listener.multisigAccountAdded() #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 25, 2019
Merged

Added #28 Listener for cosignatories -> Listener.multisigAccountAdded() #90

merged 10 commits into from
Mar 25, 2019

Conversation

rg911
Copy link
Contributor

@rg911 rg911 commented Mar 15, 2019

No description provided.

@rg911 rg911 requested a review from evias March 15, 2019 16:21
@coveralls
Copy link

Pull Request Test Coverage Report for Build 239

  • 3 of 14 (21.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 71.724%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/infrastructure/Listener.ts 3 14 21.43%
Totals Coverage Status
Change from base Build 235: 0.04%
Covered Lines: 1038
Relevant Lines: 1307
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 239

  • 3 of 14 (21.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 71.724%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/infrastructure/Listener.ts 3 14 21.43%
Totals Coverage Status
Change from base Build 235: 0.04%
Covered Lines: 1038
Relevant Lines: 1307
💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 15, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 255

  • 23 of 38 (60.53%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 71.071%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/infrastructure/transaction/CreateTransactionFromDTO.ts 15 19 78.95%
src/infrastructure/Listener.ts 3 14 21.43%
Totals Coverage Status
Change from base Build 235: -0.6%
Covered Lines: 1047
Relevant Lines: 1330
💛 - Coveralls

evias
evias suggested changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@evias evias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests under e2e for newly added methods in Listener.ts

Greg S and others added 9 commits March 16, 2019 14:55
@evias
Issue symbol#89: added Recipient class, added Namespace.createFromEnc…
7c7a78c 
…oded, added TransferTransaction.recipient Recipient capability
@evias
issue symbol#89: use auxiliary class for recipient extraction
c3f2056
@evias
issue symbol#89: differenciate mosaicId from NamespaceId with most si…
6eb054e 
…gnificant bit
@evias
issue symbol#89: updated extractRecipient to use bitwise OR operator …
3f56ed8 
…; added documentation for extractRecipient and extractMosaics
@evias
v0.11.1: added DTO fix for recipient and mosaics with aliases
be87013
@evias
Merge pull request symbol#91 from evias/task/G89/alias-in-transaction
f3ea076 
Fix issue symbol#89: Read recipient from encoded hexadecimal notation
@rg911
Added symbol#28 Listener for cosignatories -> Listener.multisigAccoun…
b7b6c24 
…tAdded()
@rg911
added e2e test for multisigAccountAdded
cb4d433
@rg911
Merge branch 'task/g28_modify_multisig_listener' of github.com:rg911/…
a2b6332 
…nem2-sdk-typescript-javascript into task/g28_modify_multisig_listener
@rg911 rg911 deleted the task/g28_modify_multisig_listener branch March 26, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evias evias evias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rg911 @coveralls @evias