Improve subs and msubs #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
certik
requested changes
Sep 29, 2016
| @@ -365,6 +365,21 @@ class DictBasic(_DictBasic, collections.MutableMapping): | |||
| def __repr__(self): | |||
| return self.__str__() | |||
|
|
|||
| def get_dict(*args): | |||
There was a problem hiding this comment.
Can you add a docstring explaining what this function is doing?
| d[K.thisptr] = V.thisptr | ||
| return c2py(symengine.ssubs(self.thisptr, d)) | ||
| #TODO: deprecate this | ||
| def subs_dict(Basic self not None, *args): |
There was a problem hiding this comment.
Just add the deprecation warnings in this PR, that way we don't need to revisit in the future.
|
|
||
| #TODO: deprecate this |
certik
approved these changes
Sep 30, 2016
|
Thank you, I think it looks good now. +1 to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.