Wrapped sech, csch, asech and acsch functions #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@isuruf Any idea why is this error coming up? |
|
Are they defined in the version we are testing with? |
|
@isuruf Not sure. How can I check for the |
ShikharJ
force-pushed
the
TrigFunctions
branch
2 times, most recently
from
203e98c to
6ba9611
Compare
|
Ping @isuruf. |
isuruf
reviewed
Mar 22, 2017
symengine/lib/symengine_wrapper.pyx
Outdated
| @@ -216,6 +230,11 @@ def sympy2symengine(a, raise_error=False): | |||
| return DenseMatrix(row, col, v) | |||
| elif isinstance(a, sympy.polys.domains.modularinteger.ModularInteger): | |||
| return PyNumber(a, sympy_module) | |||
| elif sympy.__version__ > sympy_version: | |||
There was a problem hiding this comment.
Can you replace sympy_version with 1.0? Having it as a global variable makes no sense
|
Ping @isuruf. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.