-
Notifications
You must be signed in to change notification settings - Fork 67
Test specific parts of SymPy #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bin/test_python.py
Outdated
@@ -1,3 +1,10 @@ | |||
import symengine | |||
if not symengine.test(): | |||
raise Exception('Tests failed') | |||
|
|||
print('Testing SYMPY') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to test this only on one or two jobs. (A python 2 and 3).
bin/test_python.py
Outdated
@@ -1,3 +1,23 @@ | |||
import os | |||
TEST_SYMPY = os.getenv('TEST_SYMPY', '0') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this to TEST_SYMPY = os.getenv('TEST_SYMPY', False)
, otherwise the condition will always be true.
bin/test_python.py
Outdated
import symengine | ||
if not symengine.test(): | ||
raise Exception('Tests failed') | ||
|
||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this try statement and move the lines below to under if TEST_SYMPY
?
bin/install_travis.sh
Outdated
if [[ "${TEST_SYMPY}" == "yes" ]]; then | ||
export TEST_SYMPY = 1; | ||
fi | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 lines above are unnecessary
Ping @isuruf. |
@certik, this adds less than a minute of testing time to 2 jobs. |
Thanks @ShikharJ for the PR |
Thanks, this looks great. There are some warnings from Teuchos: https://travis-ci.org/symengine/symengine.py/jobs/281611351#L1697 this might mean some kind of a bug, we should look into it. |
@certik, those warnings are unrelated. They've been there for ages. The 16 warnings are because of the 16 variables we create in |
Ok, I created an issue for the warnings: #197. |
No description provided.