Simplify lambdify #215
Merged
Simplify lambdify #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjodah
reviewed
Feb 9, 2018
| @@ -4447,7 +4447,7 @@ cdef class _Lambdify(object): | |||
| raise ValueError("Size of out incompatible with number of exprs.") | |||
| self.unsafe_complex(inp, out) | |||
|
|
|||
| def __call__(self, inp, *, out=None): | |||
| def __call__(self, *args, out=None): | |||
There was a problem hiding this comment.
This will stop us from adding a second positional argument in the future. I suppose that's alright since kw-only arguments work well.
There was a problem hiding this comment.
Yes, any new arguments can be made keyword only.
|
I think it looks good, and I can't think of any cases where this would brake anything. |
bjodah
approved these changes
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.