Skip to content

Mark subs as throwing exceptions #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Mark subs as throwing exceptions #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions symengine/lib/symengine.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,9 @@ cdef extern from "<symengine/basic.h>" namespace "SymEngine":
void cse(vec_pair &replacements, vec_basic &reduced_exprs, const vec_basic &exprs) except+ nogil

cdef extern from "<symengine/subs.h>" namespace "SymEngine":
rcp_const_basic msubs (rcp_const_basic &x, const map_basic_basic &x) nogil
rcp_const_basic ssubs (rcp_const_basic &x, const map_basic_basic &x) nogil
rcp_const_basic xreplace (rcp_const_basic &x, const map_basic_basic &x) nogil
rcp_const_basic msubs (rcp_const_basic &x, const map_basic_basic &x) except+ nogil
rcp_const_basic ssubs (rcp_const_basic &x, const map_basic_basic &x) except+ nogil
rcp_const_basic xreplace (rcp_const_basic &x, const map_basic_basic &x) except+ nogil

cdef extern from "<symengine/derivative.h>" namespace "SymEngine":
rcp_const_basic diff "SymEngine::sdiff"(rcp_const_basic &arg, rcp_const_basic &x) except+ nogil
Expand Down
8 changes: 7 additions & 1 deletion symengine/tests/test_subs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import unittest

from symengine.test_utilities import raises
from symengine import Symbol, sin, cos, sqrt, Add, function_symbol, have_numpy
from symengine import Symbol, sin, cos, sqrt, Add, function_symbol, have_numpy, log


def test_basic():
Expand All @@ -24,6 +24,12 @@ def test_sin():
assert e.subs(x, 0) == 1


def test_subs_exception():
x = Symbol("x")
expr = sin(log(x))
raises(RuntimeError, lambda: expr.subs({x: 0}))


def test_args():
x = Symbol("x")
e = cos(x)
Expand Down