This repository was archived by the owner on Sep 16, 2021. It is now read-only.
fix admin show view #210
Merged
fix admin show view #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
the content of the menu is a reference, not "text". this was the reason the problem was only detected in twig. when letting sonata figure out what field this is, it properly reports that we either need a __toString method or specify the associated_property.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sonata doctrine phpcr admin did not properly handle relations in show mode. but additionally, this admin was trying to confuse the show mapper.
this change will only help together with
sonata-project/SonataDoctrinePhpcrAdminBundle#307 - but we can merge, things won't get worse than before.