also persist the schemes property #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lsmith77
commented
Sep 29, 2014
lsmith77
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #267 |
| License | MIT |
| Doc PR | n/a |
There was a problem hiding this comment.
i think each single scheme is of type string, thus this should be type="string", no?
|
the test failure seems not related to this however, but rather a basic problem with dependencies. |
lsmith77
force-pushed
the
add_schemes_persistance
branch
from
d31035d to
dc4cbbf
Compare
lsmith77
force-pushed
the
add_schemes_persistance
branch
2 times, most recently
from
99c76a7 to
f8bde0d
Compare
|
seems like master testing is also currently broken :-/ https://travis-ci.org/symfony-cmf/RoutingBundle/jobs/33717411 |
|
now tests don't want to run anymore. did not investigate further. |
|
@wouterj / @dantleech do you have a hint here? |
|
working on a build fix here #269 |
lsmith77
force-pushed
the
add_schemes_persistance
branch
from
f8bde0d to
6f42a88
Compare
lsmith77
added a commit
that referenced
this pull request
Oct 3, 2014
also persist the schemes property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.