[WIP] Fixing bundle standards #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wouterj
commented
Aug 2, 2013
wouterj
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #28 |
| License | MIT |
| Doc PR | - |
|
this can just be merged. I decided not to fix the remaining standards for this bundle. |
|
|
||
| The blog bundle is a very much "work in progress" and will only be complete | ||
| when all the necessary pieces of the CMF are available. |
There was a problem hiding this comment.
I think it would be wise to include this caveat or something like it. This bundle IS an incomplete solution, it is blocked pending missing CMF bundles, notably TaxonomyBundle.
There was a problem hiding this comment.
lets re-add such a warning and then merge.
|
Created checklist: #31 |
|
@dbu re-added, can be merged! |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.