Use the fixed toolbar for hallo

[colinfrei]

Also, prevent the br tag from being used in titles

[dbu]

sure about this change? the other coffee files there are not needed?

[colinfrei]

In the toolbar folder there's only one other coffee file, which is for the current position. I think we could load both of them but it's not necessary.

[dbu]

from the hallo source code i see it still has this widget. can we not fix it in the sandbox to make it work again?

[colinfrei]

The overlay?

[dbu]

I think we had One to darken everything that is not the current editable area.

[colinfrei]

Yes, do we explicitly want it though, or is it a case of "it was there before, why isn't it now"?

[dbu]

the UX people wanted to do it that way. and i think it indeed made things look nicer and easier to use. if its not too hard to fix, would be nice to get it back. if its really a big pain we should open a new issue for it to not block this PR forever.

[dbu]

@colinfrei thanks for attempting to clean up things, most of it is good as is. can we do something about the overlay?

the main question now is: why do you want to use the header toolbar now? to avoid the scrolling issue? or are there other arguments?
@benoitpointet do you have any input (ux wise) regarding whether the editor in the create toolbar is better or worse than the hallo toolbar next to the text?

[benoitpointet]

@dbu could you screenshot things a bit to get an idea of the choice you're facing? I didn't follow recent works.

[dbu]

the toolbar next to text is visible here when you click into the text http://cmf.liip.ch

for the new layout i send you an email with a screenshot

[dbu]

@colinfrei i just noticed that the image dialog popup does not really work from the header toolbar. the top is hidden by the create toolbar, so i can not switch the tab and neither move or close it without first reducing the create toolbar. i think it should be positioned under the create toolbar.

[lsmith77]

btw i have updated create.js/hallo.js to the lastest version.

[lsmith77]

@colinfrei can you have a look at this tomorrow?

[dbu]

ok, so what is left:

• decide whether we want the editor in the top or next to text by default. we should make this configurable. @benoitpointet could input what should be default
• fix image dialog location when editor is in header (see my comment above)
• if we can easily re-see the overlay, would be cool

[adou600]

New status for this PR:

• the editor is on top by default, the configuration fixed_toolbar: false / true in config.yml allows to change the behavior
• the image dialog location seems to be ok, at least in the sandbox
• the overlay is shown again if configured in the editor plugin (in init-create-hallo.js)
• the type of the title was hardcoded before, with 'dcterms:title'. Now the same value is kept by default, but it can be configured in config.yml to allow another title type, for example 'cw:headline'

Should we merge?