refacto: don't extend from parser #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
commented
Apr 8, 2021
Comment on lines
+61
to
+73
| public function reference(ResolvedReference $reference, array $value): string | ||
| { | ||
| if (!$this->isSafeUrl($reference->getUrl())) { | ||
| $reference = new ResolvedReference( | ||
| $reference->getFile(), | ||
| $reference->getTitle(), | ||
| $reference->getUrl(), | ||
| $reference->getTitles(), | ||
| $this->addAttributesForUnsafeUrl($reference->getAttributes()) | ||
| ); | ||
| } | ||
|
|
||
| return $this->decoratedSpanNodeRenderer->reference($reference, $value); |
There was a problem hiding this comment.
this part was a bit tricky because BaseSpanNodeRenderer::reference() internally calls BaseSpanNodeRenderer::link() thus I had to update the attributes here inside the reference
|
Wow, yea, a bit complex on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this is a solution in response to this PR
doctrine/rst-parser#144
I used composition over inheritance for both classes where we was extending parser's classes.
This way @greg0ire could cleanly close the parser's api without exceptions.