Skip to content
This repository was archived by the owner on Jan 1, 2023. It is now read-only.

make it possible to generate cache manifest #30

Closed
wants to merge 4 commits into from
Closed

make it possible to generate cache manifest #30

wants to merge 4 commits into from

Conversation

nicam
Copy link

@nicam nicam commented Oct 3, 2011

We implemented a way to generate Cache Manifest Files in Assetic for the HTML5 Offline Mode

Offline Mode => http://diveintohtml5.org/offline.html

@lsmith77
Copy link
Contributor

lsmith77 commented Oct 3, 2011

@kriswallsmith: we are not sure if you think this fits in here, but figured why not propose it and move it else where if you don't think it belongs here. As a result tests are currently missing. Think we also still have to check if the watch mode actually works.

@kriswallsmith
Copy link
Contributor

I think this should be its own command.

@lsmith77
Copy link
Contributor

lsmith77 commented Oct 3, 2011

Within AsseticBundle? Or a different Bundle entirely?

The reason why we put it here is that in theory the assets could get out of sync if its a two step process, aka if you change the assets in between the dump of the assets and generation of the manifest file.

@lsmith77
Copy link
Contributor

@kriswallsmith: ping

@nicam
Copy link
Author

nicam commented Jan 12, 2012

ping

@schmittjoh
Copy link
Contributor

As Kris said above, can you move this to a dedicated class, e.g. ManifestGenerator? If there is nothing Symfony specific in there (which I figured from a cursory look), can you open a PR on assetic itself?

Also please add some tests, and a reference to the specification.

@schmittjoh schmittjoh closed this Mar 17, 2012
@lsmith77
Copy link
Contributor

making it is own command as @kriswallsmith said above will lead to code duplication unless the entire DumpCommand is refactored. Just moving the new dumpManifest() method to its own class as part of Assetic would however be fairly easy to do and is probably a sensible intermediate step.

@lsmith77
Copy link
Contributor

lsmith77 commented May 6, 2012

could we keep this PR open for now if only for documenting a valid open feature request. thx.

@schmittjoh schmittjoh reopened this May 6, 2012
@estahn
Copy link

estahn commented Jul 1, 2013

+1

@fabpot fabpot closed this Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants