[AIBundle] Wire & configure services explicitly #163
Conversation
valtzu
changed the title
valtzu
force-pushed
the
wire-explicitly
branch
2 times, most recently
from
570a0a3 to
bda9a1f
Compare
valtzu
force-pushed
the
wire-explicitly
branch
5 times, most recently
from
cd4c881 to
1c19fa1
Compare
|
Converted from name-based to index-based args to address #77 too Included in the same PR not to need 2 rounds of testing |
|
Wait, does the "Audio Bot" still work for you? getting this right now: |
src/ai-bundle/src/AIBundle.php
Outdated
| ->setArguments([ | ||
| $platform['api_key'], | ||
| new Reference('http_client', ContainerInterface::NULL_ON_INVALID_REFERENCE), | ||
| new Reference('ai.platform.contract.default'), |
There was a problem hiding this comment.
That's causing the error with the audio bot - it needs the Whisper contract extension, that is not part of the default, see here:
There was a problem hiding this comment.
Feels a bit counter-intuitive: I thought OpenAI was meant to be the default contract and now it seems we need a custom contract for it 🤔
Anyway, done – the audio demo works now
There was a problem hiding this comment.
The Contract is for the entire Platform - including the model Whisper, but the default is currently only for embeddings and LLM completion.
Whisper doesn't qualify to be in the default Platform contract for me, but still is part of the OpenAI Platform.
|
Thank you @valtzu. |
|
Missed a rebase here, main is broken now. 🫣 Fix in #176 |
This PR was merged into the main branch. Discussion ---------- [AIBundle] Fix dependency injection | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Docs? | no | License | MIT Fix DI config after #163 / #154. Should've rebased before merge – now we're getting a bunch of errors on `main`: ``` Symfony\AI\Agent\Toolbox\Toolbox::__construct(): Argument #1 ($tools) must be of type Traversable|array, Symfony\AI\Agent\Toolbox\ToolFactory\ReflectionToolFactory given ``` etc Commits ------- 3c6290e [AIBundle] Fix dependency injection config after #163
Don't autowire or autoconfigure anything in AI Bundle