Add readme and license headers #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Nyholm
commented
May 29, 2025
Nyholm
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| Docs? | yes |
| Issues | |
| License | MIT |
OskarStark
reviewed
May 29, 2025
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace App; | ||
|
|
||
| use PhpLlm\McpSdk\Capability\Prompt\MetadataInterface; |
There was a problem hiding this comment.
Should we adjust the namespace? Or later?
There was a problem hiding this comment.
Oh. I missed this. But I know @chr-hertel is preparing a PR to fix this. So I leave it outside of the scope of this PR.
chr-hertel
reviewed
May 29, 2025
chr-hertel
added a commit
that referenced
this pull request
Jun 6, 2025
chr-hertel
added a commit
that referenced
this pull request
Jun 13, 2025
Require `llm-php/llm-chain`
chr-hertel
added a commit
that referenced
this pull request
Jun 13, 2025
chr-hertel
pushed a commit
that referenced
this pull request
Jun 22, 2025
With the first step one should, as a last thing, execute `docker compose run composer install --no-scripts` and then call https://localhost/ and see a chatbot UI. In fact there is an exception with the Symfony App Setup instructions that the assets are not installed.
The only thing that happens during composer install is a warning to the docker container.
```
$ docker compose run composer install --no-scripts
The repository at "/app" does not have the correct ownership and git refuses to use it:
fatal: detected dubious ownership in repository at '/app'
To add an exception for this directory, call:
git config --global --add safe.directory /app
```
But this is not a problem. What is missing is the execution of the script. When i execute `docker compose run composer install` it works and there is no exception. What was your reason to not execute the scripts, that contain the import map stuff?
This was referenced Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.