Skip to content

Use $this for test assertion calls #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2025
Merged

Use $this for test assertion calls #202

merged 1 commit into from
Jul 25, 2025

Conversation

chr-hertel
Copy link
Member

Q A
Bug fix? no
New feature? no
Docs? no
Issues
License MIT

Streamlining $this->assert* instead of self::assert* in test cases based on symfony/symfony.

@chr-hertel chr-hertel requested a review from Nyholm as a code owner July 24, 2025 21:08
@chr-hertel chr-hertel added the MCP SDK Issues & PRs about the MCP SDK label Jul 24, 2025
@chr-hertel chr-hertel requested a review from OskarStark as a code owner July 24, 2025 21:08
@chr-hertel chr-hertel added Platform Issues & PRs about the AI Platform component Agent Issues & PRs about the AI Agent component Store Issues & PRs about the AI Store component AI Bundle Issues & PRs about the AI integration bundle Demo Issues & PRs about the demo application labels Jul 24, 2025
@chr-hertel chr-hertel mentioned this pull request Jul 24, 2025
Merged
@OskarStark
Copy link
Contributor

Needs a rebase

@OskarStark OskarStark changed the title Use $this for test assertion calls Use $this for test assertion calls Jul 25, 2025
@chr-hertel chr-hertel force-pushed the refactor-test-assert-this branch from 1bdaba2 to 679e964 Compare July 25, 2025 07:28
@chr-hertel chr-hertel merged commit fb18eb1 into main Jul 25, 2025
24 checks passed
@xabbuh xabbuh deleted the refactor-test-assert-this branch July 25, 2025 08:09
@chr-hertel chr-hertel mentioned this pull request Jul 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@Nyholm Nyholm Awaiting requested review from Nyholm Nyholm is a code owner

Assignees
No one assigned
Labels
Agent Issues & PRs about the AI Agent component AI Bundle Issues & PRs about the AI integration bundle Demo Issues & PRs about the demo application MCP SDK Issues & PRs about the MCP SDK Platform Issues & PRs about the AI Platform component Store Issues & PRs about the AI Store component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chr-hertel @OskarStark